Skip to content

Conversation

@chadhietala
Copy link
Contributor

@chadhietala chadhietala commented Jun 23, 2016

This supersedes #13532 and sets up the action "scoping" setting similar to how HTMLBars does it. There are couple tasks that will quickly follow once this has landed:

  • Unskip all of the glimmer tests that depend on this functionality
  • Delete some of the old action tests
  • Potentially consolidate some the tests in this PR as the implementation is roughly the same
  • More cleanup around target action (currently there are like 3 things that handle actions)

Part of #13644

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chadhietala chadhietala force-pushed the pr/13532 branch 4 times, most recently from ae70186 to f71a929 Compare June 23, 2016 23:21
@chadhietala chadhietala changed the title [WIP][Glimmer2] sendAction [Glimmer2] sendAction Jun 23, 2016
@rwjblue rwjblue merged commit 9cb7486 into emberjs:master Jun 24, 2016
@rwjblue
Copy link
Member

rwjblue commented Jun 24, 2016

Awesome work @Joelkang and @chadhietala!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants