Skip to content

Remove beta from allowed failures #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2019
Merged

Conversation

ryanto
Copy link
Contributor

@ryanto ryanto commented May 20, 2019

This PR doesn't allow addon-docs to fail in Ember beta.

The default config for ember addons will not allow beta to fail. Since addons are the most likely consumer of addon docs it's possible that they could pull in a version of addon docs that fails in Ember beta (and potentially breaks their travis builds).

Related: #363

@samselikoff samselikoff merged commit 66e533e into ember-learn:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants