Skip to content

Update ember responsive to fix broken tests on ember beta & canary builds #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2019

Conversation

sivakumar-kailasam
Copy link
Member

This PR contains the latest version of ember-responsive that fixes broken tests on latest beta & canary builds of ember addons using this addon.

Related PR: freshbooks/ember-responsive#145

@sivakumar-kailasam sivakumar-kailasam self-assigned this May 16, 2019
@sivakumar-kailasam sivakumar-kailasam changed the title Update ember responsive to solve broken tests on 3.11 Update ember responsive to fix broken tests on 3.11 May 16, 2019
@sivakumar-kailasam sivakumar-kailasam changed the title Update ember responsive to fix broken tests on 3.11 Update ember responsive to fix broken tests on ember beta & canary builds May 16, 2019
@samselikoff
Copy link
Contributor

Sweet - thanks @sivakumar-kailasam!

@samselikoff samselikoff merged commit 3cf376f into master May 16, 2019
@samselikoff samselikoff deleted the update-ember-responsive branch May 16, 2019 13:10
@sivakumar-kailasam
Copy link
Member Author

@samselikoff 👍 . Can you please publish a release?

@samselikoff
Copy link
Contributor

@sivakumar-kailasam all set https://github.com/ember-learn/ember-cli-addon-docs/releases/tag/v0.6.11

@ryanto
Copy link
Contributor

ryanto commented May 20, 2019

Heya, doesn't look like this fixes the issue (yet!). We'll first need the next version of ember-responsive to be published to npm.

@ryanto
Copy link
Contributor

ryanto commented May 20, 2019

Also while I'm here, what do you guys think about removing ember-beta as an allowed failure? I'll open a PR for that now.

My case for not allowing a failing ember-beta to pass is that the default config for ember addons will not allow beta to fail. Since addons are the most likely consumer of addon docs it's possible that you'll break their test suites if you allow beta to fail.

Ember new addon output: https://github.com/ember-cli/ember-addon-output/blob/master/.travis.yml#L31

Addon docs: https://github.com/ember-learn/ember-cli-addon-docs/blob/master/.travis.yml#L79

@sivakumar-kailasam
Copy link
Member Author

I've requested the ember-responsive maintainers to publish the changes to npm.

I think it's a good idea to allow beta builds to fail. Also, we could probably setup travis Cron jobs on our addons so that we can get notified whenever a new beta/canary builds of ember fail to work with our addons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants