Fastboot.require `dist/node_modules`

[xg-wang]

Fastboot is requireing from ...dist/node_modules before falling back to require(moduleName). src
Is this an expected behavior or should the modules be assumed to locate at same level as dist?

And the existsSync should probably be replaced with require wrapped by try-catch directly.

I found this behaviour when debugging an issue here.
A reproduction can be found at https://github.com/xg-wang/fastboot-issue to demonstrate.

[rwjblue]

RE: existsSync I agree (otherwise you have to deal with too many variances RE extension, exactly hierarchy, etc)

[rwjblue]

The current behavior of requiring from within dist is correct (modulo the fact that we should be using resolve.sync instead of existsSync).

The specific code has some assumptions:

• the thing being required is a top level package name (this is when the current existsSync would work fine). In the demo, this assumption is broken and therefore we hit the else case. This should be migrated to using resolve.sync, which would allow deep requires of specific files.
• that the dist has a node_modules structure which includes the runtime packages that are required by the app, I don’t think this should go away, but we should document it a bit better.