Dependency issue with fastboot-app-server

[Mciocca]

I am getting the following error when attempting to use an ember app that uses ember-fetch with fastboot-app-server

Error: Cannot find module 'abortcontroller-polyfill/dist/cjs-ponyfill'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.require (/Users/user/node_modules/fastboot/src/ember-app.js:130:18)
    at s.callback (/Users/user/fb-test/dist/ember-fetch/fastboot-fetch-ee5cef26e0470d371ec08fef9ba4a5b8.js:1:55)
    at s.exports (/Users/user/fb-test/dist/assets/vendor-12033a7caf9c9a2eebca95e833f776cb.js:19:21)
    at s._reify (/Users/user/fb-test/dist/assets/vendor-12033a7caf9c9a2eebca95e833f776cb.js:22:35)
    at s.reify (/Users/user/fb-test/dist/assets/vendor-12033a7caf9c9a2eebca95e833f776cb.js:21:23)
    at s.exports (/Users/user/fb-test/dist/assets/vendor-12033a7caf9c9a2eebca95e833f776cb.js:18:84)

I do not get this error when visiting the same page when serving the app with ember s

Here is a very simple app that will recreate this error when using the fastboot-app-server defaults:

https://github.com/Mciocca/fastboot-test

A co-worker was also able to recreate this error. He followed the tutorial on the ember fastboot site.

[Turbo87]

/cc @tchak @stefanpenner

[tchak]

It looks like fasboot node packages are not properly installed...

[Mciocca]

@tchak
I followed the instructions on the fastboot website. Where did I go wrong?
It could very well have been a mistake on my end or something not well documented.

[tchak]

@Mciocca I just tried your demo app and it works for me... Can I see your server.js file?

[Mciocca]

@tchak Pretty much just copy and pasted from the fastboot-app-server repo

const FastBootAppServer = require('fastboot-app-server');

const MY_GLOBAL = 'MY GLOBAL';

let server = new FastBootAppServer({
  distPath: '/Users/mciocca/fb-test/dist',
  gzip: true, // Optional - Enables gzip compression.
  host: '0.0.0.0', // Optional - Sets the host the server listens on.
  port: 4000, // Optional - Sets the port the server listens on (defaults to the PORT env var or 3000).
  sandboxGlobals: { GLOBAL_VALUE: MY_GLOBAL }, // Optional - Make values available to the Ember app running in the FastBoot server, e.g. "MY_GLOBAL" will be available as "GLOBAL_VALUE"
  chunkedResponse: true // Optional - Opt-in to chunked transfer encoding, transferring the head, body and potential shoeboxes in separate chunks. Chunked transfer encoding should have a positive effect in particular when the app transfers a lot of data in the shoebox.
});

server.start();

[xg-wang]

Are you running server.js from another location other than fastboot-test/?
I notice you're using distPath: '/Users/mciocca/fb-test/dist', and the example is distPath: 'dist',.

If you are running server.js from another location without node_modules having your dependencies the error would be thrown.

[xg-wang]

So I played around with it and had these results:

Fastboot is require'ing from <your-app>/dist/node_modules/<module-name>, but the node_modules are not actually bundled into dist, they are at <your-app>/node_modules/<module-name> instead. The above case results in existsSync check fails for both node-fetch and abortcontroller-polyfill/dist/cjs-ponyfill in this test.

When the check fails, Fastboot does require('abortcontroller-polyfill/dist/cjs-ponyfill')

• This succeeds when you serve express server from project root
• But it FAILs when you serve from anothe location

---

Then I changed to the actual path let nodeModulesPath = path.join(distPath, '..', 'node_modules', moduleName);src.
Now require('<absolute-path-to>node-fetch') succeeds but require('<absolute-path-to>abortcontroller-polyfill/dist/cjs-ponyfill') fails.
I have to do require('absolute-path-to>abortcontroller-polyfill/dist/cjs-ponyfill.js') and it will work.

---

Conclusion:

• To fix it @Mciocca can do node server.js from fastboot-test/
• There's a <bug?> in Fastboot to read the node_modules
• ember-fetch should require .js file here and announce fastboot dep as .js. I need to check node's documentation about this.

[xg-wang]

/cc @thoov
About the node_modules were missing in dist, I remember you were doing something related?

[mhluska]

@xg-wang so what's the fix here? I'm already running node server.js in the project root. I tried rolling back ember-fetch from v5 to v4 with no improvement. I also tried appending .js to the require but the error persists.

[mhluska]

I ended up getting this working by doing npm install --save abortcontroller-polyfill in my fastboot repo. It's not great but a temporary workaround that lets me deploy again until this is fixed.

[kratiahuja]

@xg-wang you shouldn't ideally need node_modules in dist if you don't have any whitelisted packages.