-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Merge main into v2 #2116
base: v2.0.0
Are you sure you want to change the base?
WIP: Merge main into v2 #2116
Conversation
Since there no more duplicate class names you can run |
Instruction reranking were added in #1359 after unifing retrieval and reranking
Yes, that's correct
I think you've fixed it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Just had a look at the original pr - back then it was |
To load BuiltBenchReranking correctly you need to put it in mteb/mteb/abstasks/AbsTaskReranking.py Lines 13 to 30 in 056c09a
I'm removing this in #2097 |
Failures seems to be HF failures. Will try to rerun to see if it resolves it |
I think we should modify |
descriptive_stat_path
, I am not entirely sure if the merge is correct here.python-iso639
? (seems like the test passed because try except loop).for now I just calculated the desc. stats over on main and moved it over.
Note: we are likely missing some task imports in v2 (it is impossible to know with the star imports) - any good way to check?I used the now outdated category to check.It might be nice to start doing these merges more often?
Code Quality
make lint
to maintain consistent style.Documentation
Testing
make test-with-coverage
.make test
ormake test-with-coverage
to ensure no existing functionality is broken.