-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] reupload reranking datasets in old format #2097
base: v2.0.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Samoed, thanks for finalizing this.
My only question is does this affect the listing of tasks? e.g. what distinguishes reranking vs retrieval now, when you load with the mteb.load_tasks for reranking only? I would assume we need some mapping now to maintain that they are reranking tasks.
EDIT: perhaps that's in the task meta? If so then I have no concerns.
These tasks will still have |
Closes #1878
Code Quality
make lint
to maintain consistent style.Documentation
Testing
make test-with-coverage
.make test
ormake test-with-coverage
to ensure no existing functionality is broken.@orionw Can you review, please?