Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes #101

Merged
merged 6 commits into from
Dec 20, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix view-mode feature test
calc-units does not use view-mode in emacs 25
  • Loading branch information
felipeochoa committed Dec 4, 2017
commit ee68b64f9840675df59a54be3c0ffaeee6869cb6
5 changes: 2 additions & 3 deletions features/predicates-disable.feature
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Feature: Predicate based disable
And I am in buffer "god-mode-test"
And I describe function "god-mode"
And I grep current directory
And I view the units table
And I start ielm

Scenario: God mode is automatically enabled for fundamental-mode
Expand All @@ -19,8 +18,8 @@ Feature: Predicate based disable
When I switch to buffer "*grep*"
Then god-mode is disabled

Scenario: God mode is disabled in *Units Table* (has view-mode enabled)
When I switch to buffer "*Units Table*"
Scenario: God mode is disabled in buffers with view-mode
When I open a view-mode buffer
Then god-mode is disabled

Scenario: God mode is disabled in comint derived buffers
Expand Down
8 changes: 5 additions & 3 deletions features/step-definitions/god-mode-steps.el
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@
(get-buffer-process (grep "grep -Rin god ."))
nil)))

(Given "^I view the units table$"
(Given "^I open a view-mode buffer"
(lambda ()
(require 'calc-units)
(math-build-units-table-buffer nil)))
(set-buffer (get-buffer-create "*view-mode-buffer*"))
(view-mode)
(god-local-mode 0)
(god-mode-maybe-activate)))

(Given "^I start ielm$"
(lambda ()
Expand Down