Test fixes #101
Merged
Test fixes #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calc-units does not use view-mode in emacs 25
Espuds' "I press" does its own translation of key sequences, whereas its "I type" step requires typing control characters into the string.
|
You can see the travis result for this branch here |
|
@chrisdone bump |
|
That's a lot of PRs. Which do I merge next? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a different PR, but a lot of tests were failing with Emacs 25. The first thing I did was fix these various failures and set up a travis config to run against Emacs 24, 25, and snapshot. After making these changes, there's still a test failure (uud does delete 16 times), which is a real issue (at least on Emacs 25) requiring a fix.