Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @vueuse/core from 10.8.0 to 10.9.0 #2674

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Mar 10, 2024

probably fix #2628

There was an GitHub Issue for useActiveElement in the @vueuse/core repository, which was fixed by the latest version 10.9.0: vueuse/vueuse#3799.

We are using almost the same logic for our keyboard shortcuts here:

// disable shortcuts when focused on inputs (https://vueuse.org/core/usemagickeys/#conditionally-disable)
const activeElement = useActiveElement()
const notUsingInput = computed(() =>
activeElement.value?.tagName !== 'INPUT'
&& activeElement.value?.tagName !== 'TEXTAREA'
&& !activeElement.value?.isContentEditable,
)
const isAuthenticated = currentUser.value !== undefined

Also, confirmed this issue was fixed: #2612 (comment)

Copy link

stackblitz bot commented Mar 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 64730a8
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65eddc11ae984a00085ee63c

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 64730a8
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65eddc11af3359000815ccb4
😎 Deploy Preview https://deploy-preview-2674--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@vueuse/core@10.9.0 environment, network +3 1.92 MB antfu

View full report↗︎

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@patak-dev patak-dev added this pull request to the merge queue Mar 10, 2024
Merged via the queue into elk-zone:main with commit ed8a181 Mar 10, 2024
16 checks passed
@shuuji3 shuuji3 deleted the chore/upgrade-vueuse-core branch March 11, 2024 01:47
maybeanerd pushed a commit to maybeanerd/crab that referenced this pull request Mar 11, 2024
@lazzzis lazzzis mentioned this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts stop working after the first one
2 participants