Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: . shortcut to show new items #2612

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

patak-dev
Copy link
Member

This should work, but I couldn't test it properly. We have an issue with the subscription to the federated stream it seems, maybe to other streams too.

@patak-dev patak-dev added the c: feature Request for new feature label Feb 24, 2024
Copy link

stackblitz bot commented Feb 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit f5f3501
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65d9f81149831b0008818b70

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit f5f3501
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65d9f8117dd45d0008caa36f
😎 Deploy Preview https://deploy-preview-2612--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3
Copy link
Member

shuuji3 commented Feb 24, 2024

Hmm, it looks like something is invalidating the magic keys feature.

When I tried the following, it didn't work:

    • Open Elk
    • Type ? to see if the magic keys is working -> OK
    • Click the "Federated" icon on the nav bar
    • Type ? to see if the magic keys is working -> stop working
    • Type . -> nothing happens

But the following works as expected:

  1. Open Elk
  2. Type ? to see if the magic keys is working -> OK
  3. Type Ctrl+/ to avoid clicking the icon
  4. Type federated and Enter
  5. Type ? to see if the magic keys is working -> OK
  6. Type . -> reloaded new posts👌🏻

Also, directly opening the federated tab (https://deploy-preview-2612--elk-zone.netlify.app/universeodon.com/public) works.

I think we can merge this new shortcut and fix something that breaks the magic keys later separately.

@patak-dev patak-dev added this pull request to the merge queue Feb 24, 2024
@patak-dev
Copy link
Member Author

We saw some issues with MagicKeys with @userquin after updating Vue to 3.4, it could be something in VueUse or on our side. Let's merge this one as it should be unrelated as you explained

Merged via the queue into main with commit 3769176 Feb 24, 2024
15 checks passed
@patak-dev patak-dev deleted the feat/use-dot-to-show-new-items branch February 24, 2024 14:49
shuuji3 pushed a commit to shuuji3/elk that referenced this pull request Feb 29, 2024
shuuji3 pushed a commit to shuuji3/elk that referenced this pull request Feb 29, 2024
@meyerweb
Copy link

meyerweb commented Mar 7, 2024

I’ve noticed that this (maybe all magic keys?) seems to fail after I switch to a new tab and then come back to the Elk tab. I usually switch tabs using keyboard shortcuts (e.g., ⌥⌘→) so I don’t know if that’s triggering a failure state or not. If I ever manage to get it fully reproducible, I’ll report back in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants