-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: . shortcut to show new items #2612
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hmm, it looks like something is invalidating the magic keys feature. When I tried the following, it didn't work:
But the following works as expected:
Also, directly opening the federated tab (https://deploy-preview-2612--elk-zone.netlify.app/universeodon.com/public) works. I think we can merge this new shortcut and fix something that breaks the magic keys later separately. |
We saw some issues with MagicKeys with @userquin after updating Vue to 3.4, it could be something in VueUse or on our side. Let's merge this one as it should be unrelated as you explained |
I’ve noticed that this (maybe all magic keys?) seems to fail after I switch to a new tab and then come back to the Elk tab. I usually switch tabs using keyboard shortcuts (e.g., ⌥⌘→) so I don’t know if that’s triggering a failure state or not. If I ever manage to get it fully reproducible, I’ll report back in a new issue. |
This should work, but I couldn't test it properly. We have an issue with the subscription to the federated stream it seems, maybe to other streams too.