Fix Summary Types heading size #2192
Conversation
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/21399132754/artifacts/5272472694 |
DavidOliver
force-pushed
the
summary-headings
branch
from
56af58b to
30afb0c
Compare
DavidOliver
force-pushed
the
summary-headings
branch
from
30afb0c to
a53f365
Compare
|
@DavidOliver I am afraid this fix is not correct. ExDoc allows you to define custom groups and, if we target the headers IDs here, then custom groups won't be correct. We need to add a generic selector. If it is not possible today without partially undoing #2164, then we can add new selectors to the template. |
|
@DavidOliver perhaps a simple answer is to convert those to h2 and h3 in the template, so they don't need the special selectors no more. |
Ah - sorry!
I've just tried that and it's looking like it's going to work fine. I'll spend some more time checking and trying to find issues before pushing again. |
|
Okay - I believe main headings are now level context-correct, which makes styling them simpler and more reliable. The 'Types' Summary subheading is now correctly sized. docstring headings continue to be handled via the .docstring class. I took the opportunity to tweak them, very slightly opening up their margin-top spacing and making h4 smallcaps to distinguish from h3. 
Before
After
|
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
This is perfect! ❤️
Let's add minification back and I can ship a new release!!!!
Previously, it seemed that esbuild was adding erroneous spaces in
':is(', but that isn't happening now. All minification is now enabled
whether in watch/dev mode or not, so that devs get the same results as a
production build. (Browsers do a good job of un-minifying for
inspection.)
|
Even though whitespace minification is enabled, I can no longer find any erroneous spaces in ':is('. Not sure what happened there. All minification is now enabled whether in watch/dev mode or not, so that devs get the same results as a production build. (Browsers do a good job of un-minifying for inspection.) |
2 participants
Fixes #2191