Better differentiate headings/sections #2164
Merged
+61
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/18915321163/artifacts/4408323918 |
josevalim
previously approved these changes
Oct 27, 2025
DavidOliver
changed the title
DavidOliver
dismissed
josevalim’s stale review
These subsequent commits haven't yet been tried out.
|
@DavidOliver I will mark it as ready for review so it publishes the precompiled archives for validation. :) |
|
Gah, my bad, it was not necessary, I just missed the updated comment at the top :D |
DavidOliver
force-pushed
the
headings-scale-2
branch
from
3f75205 to
a1a9363
Compare
|
Selector tweak and related necessary updates made. Ready for final check and approval. |
josevalim
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re. #2150
@josevalim, in the previous PR, module heading spacing (under "Summary", for example) and cheatsheets were affected, as well as admonition block headings as you pointed out.
This PR changes approach and attempts to target only "top content" in "module" and "extra" pages, and only those headings which are direct children of the #top-content element.
I'll test further before converting to a full/non-draft PR, but I thought I'd put this up to see what you think of this approach.