General build upgrades and improvements #1

sgammon · 2024-02-19T06:29:49Z

Summary

Draft. Coming soon. Probably will not get merged.

Full changelog

feat: support for build scans with gradle enterprise
feat: support for caching with buildless (inert without key)
feat: support for gradle java toolchains
feat: support for static analysis with detekt
feat: support for toolchain vs. runtime target
feat: support for dynamic provisioning of toolchains
feat: support for static java checking with pmd
feat: enable typed project accessors, use them project-wide
feat: stricter repositories, locking for build classpath
feat: property to retarget java or kotlin bytecode versions
feat: parameter name integration between javac and kotlinc
feat: kotlin coverage support via kover plugin
feat: dependency verification for gradle build
feat: support for new gradle jvm-test-suite plugin
feat: reasonable local and remote build caching support
feat: project icon in intellij new ui
feat: aggregate reporting for tests, coverage, detekt
fix: repeatable/consistent archives from gradle
fix: don't list ephemeral spotless configurations in lockfiles
fix: make version catalog symbols available in buildSrc
fix: specify rootProject.name for buildSrc
fix: error when running gradlew tasks
fix: various java or gradle deprecations
fix: move all tool (linter, etc) versions into version catalog
chore: add testlogger for clearer test outcomes
chore: check build configuration with gradle doctor plugin
chore: generate initial suite of dependency verification material
chore: transition to property set syntax (property = xyz)
chore: cleanup uses of buildDir (becomes layout.buildDirectory)
chore: add Gradle Versions plugin for update checks
chore: upgrade Gradle → 8.6 (supports Java 21)
chore: upgrade Kotlin → 1.9.22 (build-time)
chore: upgrade KotlinX Serialization → 1.6.3
chore: upgrade KotlinX HTML → 0.11.0
chore: general dependency upgrades, where safe

Not yet completed

feat: signing of artifacts with sigstore
feat: embedding of SPDX SBOM in artifacts
feat: dependency vulnerability checks with owasp
test: checksum failures

buildSrc/src/main/kotlin/BuildInfo.kt

    if (project === project.rootProject) {
-      Runtime.getRuntime()
-        .exec("git rev-parse --short HEAD", arrayOf(), project.rootDir)
+      ProcessBuilder("git", "rev-parse", "--short", "HEAD")


This fixes many "unknown symbol" errors in Java source files.

sgammon · 2024-02-20T21:16:08Z

Next batch:

feat: refactor buildSrc → composite build
feat: move to entrypoint convention for cli
chore: project descriptions for gradle
chore: restore and align build caching

Access to field "isClosed" must be guarded.

The only call site already resolved the path against tmpDir.

Replace the legacy "compile" scope with "implementation". This matches Maven Central's recommended syntax: https://central.sonatype.com/artifact/org.pkl-lang/pkl-core

…s. (apple#218) This makes the class more closely follow Java conventions.

The referenced filename should be `ispklTutorialPart3.pkl`, not `pklTutorial.pkl`. Also, changes dates from 2023 to 2024 Co-authored-by: grant-abbott <gaabbott@apple.com>

Adds an icon for the Pkl project which is used in IDEA's "New UI" when opening Pkl

This small change fixes a bug introduced by the `validatePom` task within the `pklPublishLibrary` plugin. When running project-wide tasks like `./gradle tasks`, projects which don't provide a POM fail the build, because the `generatePomFileForLibraryPublication` cannot be found, but it is expected to be present. Fixes and closes apple#215 Signed-off-by: Sam Gammon <sam@elide.ventures>

This change activates the `TYPESAFE_PROJECT_ACCESSORS` feature preview in Gradle, and switches to such accessors instead of string-based project references, where possible Relates-To: apple#204 Signed-off-by: Sam Gammon <sam@elide.ventures>

It is customary to separate elements with a semicolon.

- fix: make version catalog accessible from `buildSrc` plugins - chore: declare `googleFormatVersion` in version catalog - chore: declare `ktfmt` in version catalog Relates-To: apple#204 Signed-off-by: Sam Gammon <sam@elide.ventures>

codecov · 2024-02-22T01:42:33Z

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Fixes and closes apple#191 Signed-off-by: Sam Gammon <sam@elide.ventures>

Adds a setting to the Kotlin code generator which controls the target Kotlin package for codegen. Applied as a prefix to the normal generated package name. The current versions of the `kotlinx.serialization` and `kotlinx.html` libraries are declared dynamically, which causes a failure when refreshing dependencies. To avoid Kotlin metadata build issues, these have been pinned. - feat(codegen): use `kotlinPackage` as prefix for kotlin codegen - feat(gradle): `kotlinPackage` property in gradle plugin - test(codegen): add tests for custom kotlin package - test(gradle): add tests for generating with custom kotlin package Signed-off-by: Sam Gammon <sam@elide.ventures>

This change adds support for a new code-gen argument, `implementKSerializable`, which results in the annotation `kotlinx.serialization.Serializable` being added to `data` classes during codegen. Relates to discussion apple#185 - feat(codegen): add support for kotlin `Serializable` annotation - feat(gradle): add `implementKSerializable` argument - test(codegen): add test for KotlinX serialization support - test(codegen): add test for both Java and KotlinX serialization - test(gradle): add test for compiling with KotlinX serialization Signed-off-by: Sam Gammon <sam@elide.ventures>

- feat: support for build scans with gradle enterprise - feat: support for caching with buildless (inert without key) - feat: support for gradle java toolchains - feat: support for static analysis with detekt - feat: support for gradle toolchains - feat: support for toolchain vs. runtime target - feat: support for dynamic provisioning of toolchains - feat: support for static java checking with pmd - feat: enable typed project accessors, use them project-wide - feat: stricter repositories, locking for build classpath - feat: property to retarget java or kotlin bytecode versions - feat: parameter name integration between javac and kotlinc - feat: kotlin coverage support via `kover` plugin - feat: dependency verification for gradle build - feat: support for new gradle `jvm-test-suite` plugin - feat: reasonable local and remote build caching support - feat: project icon in intellij new ui - feat: aggregate reporting for tests, coverage, detekt - fix: repeatable/consistent archives from gradle - fix: don't list ephemeral spotless configurations in lockfiles - fix: make version catalog symbols available in `buildSrc` - fix: specify `rootProject.name` for `buildSrc` - fix: error when running `gradlew tasks` - fix: various java or gradle deprecations - fix: move all tool (linter, etc) versions into version catalog - chore: add testlogger for clearer test outcomes - chore: check build configuration with gradle doctor plugin - chore: generate initial suite of dependency verification material - chore: transition to property set syntax (`property = xyz`) - chore: cleanup uses of `buildDir` (becomes `layout.buildDirectory`) - chore: add Gradle Versions plugin for update checks - chore: upgrade Gradle → `8.6` (supports Java 21) - chore: upgrade Kotlin → `1.9.22` (build-time) - chore: upgrade KotlinX Serialization → `1.6.3` - chore: upgrade KotlinX HTML → `0.11.0` - chore: general dependency upgrades, where safe Not yet completed: - feat: signing of artifacts with sigstore - feat: embedding of SPDX SBOM in artifacts - feat: dependency vulnerability checks with owasp - test: checksum failures Signed-off-by: Sam Gammon <sam@elide.ventures>

Signed-off-by: Sam Gammon <sam@elide.ventures>

sgammon added 🚧 WIP Work-in-progress 🧪 labs Experimental work labels Feb 19, 2024

sgammon self-assigned this Feb 19, 2024

github-advanced-security bot found potential problems Feb 19, 2024

View reviewed changes

sgammon force-pushed the chore/build-upgrades branch from c8958e4 to 641f38e Compare February 19, 2024 06:59

sgammon mentioned this pull request Feb 19, 2024

General build upgrades and improvements apple/pkl#198

Closed

Mark generated/truffle as generated source dir in IntelliJ

277f1e0

This fixes many "unknown symbol" errors in Java source files.

sgammon force-pushed the chore/build-upgrades branch from 4c0b0a8 to 8e087be Compare February 20, 2024 21:16

Fix concurrency bug in PackageResolvers (apple#220)

ffc629f

Access to field "isClosed" must be guarded.

sgammon force-pushed the chore/build-upgrades branch from 8e087be to 3c9c2a1 Compare February 21, 2024 02:29

odenix and others added 11 commits February 20, 2024 20:47

Fix unnecessary temp path resolution in PackageResolvers (apple#219)

91367ed

The only call site already resolved the path against tmpDir.

Update Gradle syntax in docs (apple#210)

6175d16

Replace the legacy "compile" scope with "implementation". This matches Maven Central's recommended syntax: https://central.sonatype.com/artifact/org.pkl-lang/pkl-core

Breaking: add private final modifier to InvalidMappingException field…

dd49236

…s. (apple#218) This makes the class more closely follow Java conventions.

Fix incorrect filename in tutorial

1cfcc5e

The referenced filename should be `ispklTutorialPart3.pkl`, not `pklTutorial.pkl`. Also, changes dates from 2023 to 2024 Co-authored-by: grant-abbott <gaabbott@apple.com>

make reflected values renderable (apple#170)

611ab3b

Add IDEA project icon

fc0f6f1

Adds an icon for the Pkl project which is used in IDEA's "New UI" when opening Pkl

Use Gradle typed project accessors

1e50200

This change activates the `TYPESAFE_PROJECT_ACCESSORS` feature preview in Gradle, and switches to such accessors instead of string-based project references, where possible Relates-To: apple#204 Signed-off-by: Sam Gammon <sam@elide.ventures>

Tweak User-Agent header

21e0e14

It is customary to separate elements with a semicolon.

Move tool versions to Version Catalog

ca31185

- fix: make version catalog accessible from `buildSrc` plugins - chore: declare `googleFormatVersion` in version catalog - chore: declare `ktfmt` in version catalog Relates-To: apple#204 Signed-off-by: Sam Gammon <sam@elide.ventures>

fix typo in doc for Listing default (apple#224)

c652bbe

sgammon force-pushed the chore/build-upgrades branch 3 times, most recently from 72e31b6 to 7bd65d4 Compare February 22, 2024 00:07

sgammon added 4 commits February 21, 2024 18:01

Fix dropped implementSerializable flag

2f12dbd

Fixes and closes apple#191 Signed-off-by: Sam Gammon <sam@elide.ventures>

sgammon added 30 commits February 21, 2024 18:31

chore: update api pins

d87184f

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! don't relocate kotlinx in fat jar

5f2dd08

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! kotlinx-html relocations

adc28b9

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! don't use matrix for regular build

e9ee73e

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix: kotlinx html relocations

2af98f8

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: continued support for jpms

a6f2e5f

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: add PklExperimental kotlin opt in

26f01da

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! run spotless

77e050f

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! relocations for kotlin

e58d7c0

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! jpms / kotlin task dependencies

dcf620a

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: module info for pkl-commons-cli

69ece80

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix: exclude duplicates in main jar for kotlin/jvm compilations

0f7a88b

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix: attempt a sleep to solve race condition between kotlinc/javac

23919f4

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! module build for pkl-commons-cli

69ed70c

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! honor dependency locking toggle in build-logic

9406aba

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: jpms module for pkl-commons-test

0d0574d

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! cleanup pure kotlin conventions

3a663d3

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: jpms for pkl-doc

a510e40

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: jpms for pkl-executor

6fd45a5

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix: build before native target in ci

43ca558

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: jpms for pkl.server

779060b

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix: close module pkl.core

8088af9

Signed-off-by: Sam Gammon <sam@elide.ventures>

chore: run spotless

a31ea15

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! remove old add-reads for executor

55336a5

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! jpms for server module

d1c3e02

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix: rollback jpms for server (msgpack is blocking it)

c3ca8a8

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix: jpms with native build

28c9737

Signed-off-by: Sam Gammon <sam@elide.ventures>

feat: modular antlr4 and paguro dependencies

45bad1f

Signed-off-by: Sam Gammon <sam@elide.ventures>

fix!: expose pkl-executor as api dependency

f81ea3c

Signed-off-by: Sam Gammon <sam@elide.ventures>

fixup! relocations for slf4j

f7938ee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

General build upgrades and improvements #1

General build upgrades and improvements #1

Uh oh!

sgammon commented Feb 19, 2024 •

edited

Loading

Uh oh!

Check failure

sgammon commented Feb 20, 2024

Uh oh!

codecov bot commented Feb 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

General build upgrades and improvements #1

Are you sure you want to change the base?

General build upgrades and improvements #1

Uh oh!

Conversation

sgammon commented Feb 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Full changelog

Not yet completed

Uh oh!

Check failure

sgammon commented Feb 20, 2024

Uh oh!

codecov bot commented Feb 22, 2024

Welcome to Codecov 🎉

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sgammon commented Feb 19, 2024 •

edited

Loading