Skip to content

Conversation

@manuelsblanco
Copy link
Contributor

Hi pkl team

I hope this message finds you well.

I've made some enhancements to the code in the InvalidMappingException class located at

pkl-config-java/src/main/java/org/pkl/config/java/InvalidMappingException.java.

The changes aim to improve code consistency by utilizing the final modifier for certain variables.

I would love to get involved in this new exciting language.

The best

Manuel

manuelsblanco and others added 2 commits February 20, 2024 22:26
This is a breaking change that we'll add to our notes for version 0.26
@bioball
Copy link
Member

bioball commented Feb 21, 2024

Thanks! They should really both adhere to Java conventions and both be private too. This will be a breaking change, but it's a pretty minor one. We'll note this in our 0.26 release notes.

@bioball bioball merged commit dd49236 into apple:main Feb 21, 2024
@manuelsblanco manuelsblanco deleted the may_have_final branch February 21, 2024 12:54
@manuelsblanco
Copy link
Contributor Author

Thanks! They should really both adhere to Java conventions and both be private too. This will be a breaking change, but it's a pretty minor one. We'll note this in our 0.26 release notes.

do you want me to make those changes or should we wait?

@holzensp
Copy link
Collaborator

holzensp commented Feb 21, 2024

@bioball rolled those changes in. No further action required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants