Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests that modify push rules cannot be routed to workers #13382

Open
matrixbot opened this issue Dec 20, 2023 · 1 comment
Open

Requests that modify push rules cannot be routed to workers #13382

matrixbot opened this issue Dec 20, 2023 · 1 comment

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023

This issue has been migrated from #13382.


matrix-org/synapse#5063 allowed worker processes to service read-only push rule-related endpoints. This is an issue to track the remaining push rule-related endpoints that require writes.

The following endpoints cannot yet be routed to worker processes:

I believe this hinges on converting the push rules stream to use a MultiWriterIdGenerator, instead of what we have today? https://github.com/matrix-org/synapse/blob/0d1d3e070886694eff1fa862cd203206b1a63372/synapse/storage/databases/main/push_rule.py#L132-L139

We did a similar piece of work for moving presence off of the main process.

@matrixbot matrixbot changed the title Dummy issue Requests that modify push rules cannot be routed to workers Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
@olmari
Copy link
Contributor

olmari commented Apr 17, 2024

Is this now solved with #17037 and #17038 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants