Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Requests that modify push rules cannot be routed to workers #13382

Open
anoadragon453 opened this issue Jul 25, 2022 · 0 comments
Open

Requests that modify push rules cannot be routed to workers #13382

anoadragon453 opened this issue Jul 25, 2022 · 0 comments
Labels
A-Push Issues related to push/notifications A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@anoadragon453
Copy link
Member

#5063 allowed worker processes to service read-only push rule-related endpoints. This is an issue to track the remaining push rule-related endpoints that require writes.

The following endpoints cannot yet be routed to worker processes:

I believe this hinges on converting the push rules stream to use a MultiWriterIdGenerator, instead of what we have today?

if hs.config.worker.worker_app is None:
self._push_rules_stream_id_gen: AbstractStreamIdTracker = StreamIdGenerator(
db_conn, "push_rules_stream", "stream_id"
)
else:
self._push_rules_stream_id_gen = SlavedIdTracker(
db_conn, "push_rules_stream", "stream_id"
)

We did a similar piece of work for moving presence off of the main process.

@anoadragon453 anoadragon453 added A-Push Issues related to push/notifications A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Push Issues related to push/notifications A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

1 participant