This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Notification using MessagingStyle #2880

Merged

bmarty merged 33 commits into develop from feature/notification_rework

Mar 18, 2019

Member

bmarty commented Jan 17, 2019 •

edited

Loading

We create this WIP pull request to make this work publicly visible
Fixes #2823
Fixes #1016

Member Author

bmarty commented Jan 17, 2019

@thelimitbreaker you may be interested to give some feedback on this / new idea, as you were proposing to help us on this subject

BillCarsonFr force-pushed the feature/notification_rework branch from d7d1f52 to 4a094d7 Compare

January 17, 2019 17:13

Contributor

RotBolt commented Jan 18, 2019

@bmarty yes ! You said once the Notifications channel is done . I would be able to do the part for Notifications . For which I also posted the sample screenshots. In #2823 . It would be good if Riot would implement the notifications in that style since it's chat app

Member Author

bmarty commented Jan 21, 2019

@bmarty yes ! You said once the Notifications channel is done . I would be able to do the part for Notifications . For which I also posted the sample screenshots. In #2823 . It would be good if Riot would implement the notifications in that style since it's chat app

Actually this PR implements #2823

bmarty mentioned this pull request

Support Android 7.0 inline notification replies #1016

Closed

Contributor

RotBolt commented Jan 22, 2019

@bmarty ok . So I would also work on this . I thought this just for Channels .
Once I fix my machine dependencies and become free from My Talk . I will start doing work on this . Is that fine ?

Member Author

bmarty commented Jan 22, 2019

@thelimitbreaker , yes.
@BillCarsonFr told me that the PR is ready for review, so next step is to review code and test the feature on various devices.
I will be happy to merge the PR quite quickly, to make the code land to develop and get feedbacks from the early adopters downloading the APK from Jenkins
Benoit

bmarty changed the title ~~Notification rework - WIP~~ Notification using MessagingStyle

bmarty added this to the Sprint 18 milestone

bmarty commented

View reviewed changes

Member Author

bmarty left a comment

Great work!
Here is some remarks :)

CHANGES.rst Outdated Show resolved Hide resolved

vector/src/app/java/im/vector/push/fcm/VectorFirebaseMessagingService.kt Show resolved Hide resolved

vector/src/app/java/im/vector/push/fcm/VectorFirebaseMessagingService.kt Show resolved Hide resolved

vector/src/app/java/im/vector/push/fcm/VectorFirebaseMessagingService.kt Show resolved Hide resolved

vector/src/app/java/im/vector/push/fcm/VectorFirebaseMessagingService.kt Outdated Show resolved Hide resolved

vector/src/main/java/im/vector/services/EventStreamService.java Outdated

-                                  refreshMessagesNotification();
-                              }
-                          });

Member Author

bmarty Jan 22, 2019

This code does nothing then.
Either it should do something, else we can remove it.
BingRules update are managed somewhere else now?

Member

BillCarsonFr Jan 23, 2019

No i think it can be removed. I am not sure it makes sense to reorganize all already recieved notifications when rules have changed.

vector/src/main/java/im/vector/services/EventStreamService.java Outdated

@@ @@ -233,23 +194,41 @@ public void run() { @@
                   private final MXEventListener mEventsListener = new MXEventListener() {
                       @Override
                       public void onBingEvent(Event event, RoomState roomState, BingRule bingRule) {
+                          Log.d(LOG_TAG, "%%%%%%%%  MXEventListener: the event " + event);

Member Author

bmarty Jan 22, 2019

Please remove this log (privacy)

vector/src/main/java/im/vector/services/EventStreamService.java Show resolved Hide resolved

vector/src/main/java/im/vector/services/EventStreamService.java Outdated

                           Notification notification = NotificationUtils.INSTANCE.buildIncomingCallNotification(
                                   EventStreamService.this,
                                   isVideo,
-                                  RoomsNotifications.getRoomName(getApplicationContext(), session, room, event),
+                                  room.getRoomDisplayName(this)/*RoomsNotifications.getRoomName(getApplicationContext(), session, room, event)*/,

Member Author

bmarty Jan 22, 2019

remove commented code

vector/src/main/java/im/vector/services/EventStreamService.java Outdated

+                                  PowerManager pm = (PowerManager) getSystemService(Context.POWER_SERVICE);
+                                  PowerManager.WakeLock wl = pm.newWakeLock(
+                                          WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON | PowerManager.ACQUIRE_CAUSES_WAKEUP,
+                                          "riot:MXEventListener");

Member Author

bmarty Jan 22, 2019

rename the tag

bmarty added the feature:notification label

Contributor

RotBolt commented Jan 24, 2019

I am afraid , I couldn't couldn't contribute to this one . 😓.

How can I download the apk from Jenkins Benoit. Atleast , I would like to test it . Or is there something else I could do ?

Member Author

bmarty commented Jan 24, 2019

I am afraid , I couldn't couldn't contribute to this one . 😓.

How can I download the apk from Jenkins Benoit. Atleast , I would like to test it . Or is there something else I could do ?

You should be able to checkout Valere's branch feature/notification_rework to build and deploy the APK

Contributor

RotBolt commented Jan 27, 2019

I am afraid , I couldn't couldn't contribute to this one . sweat.
How can I download the apk from Jenkins Benoit. Atleast , I would like to test it . Or is there something else I could do ?

You should be able to checkout Valere's branch feature/notification_rework to build and deploy the APK

Cool On to it now .From the past few days machine was broke. Now onto it.

Contributor

RotBolt commented Jan 27, 2019

I am getting this during building

Problem is in im/vector/actvity/policies/AccountCreationTermsPolicy

List<LocalizedFlowDataLoginTerms> is used for sending the data through intent but
list of data from intent should be of Parceable Type.

LocalizedFlowDataLoginTerms is defined in matrix sdk. jar. So can't edit this class.

Possible solution :

LocalizedFlowDataLoginTerms contains String members
just make new ParceableLocalizedFlowDataLoginTerms . this version will implement the Parceable and copy the contents of 'LocalizedFlowDataLoginTerms'.

And then we can use this for sending the List from
LoginActvity to AccountCreationTermsPolicy

Member Author

bmarty commented Jan 28, 2019

@thelimitbreaker this compilation issue is observed because the Android Matrix SDK library is not up to date until the next release. Please follow instructions here to fix the compilation issue.

bmarty modified the milestones: Sprint 18, Sprint 19

Contributor

RotBolt commented Jan 28, 2019

@bmarty thank you for pointing that. Able to do it

Contributor

RotBolt commented Jan 31, 2019

@bmarty Sorry for the delay
I found App is crashing on opening room settings

Reason is error in inflating in XML files as seen in this

Reason of crash I found is use of ?attr/colors in layout xml. Use of colors mentioned in colors.xml make the app working

ghost mentioned this pull request

Odd notification behavior on Tizen (Samsung) wearables #2909

Open

BillCarsonFr force-pushed the feature/notification_rework branch from c87adfa to 0d6f277 Compare

February 4, 2019 09:53

BillCarsonFr force-pushed the feature/notification_rework branch from 80276a4 to 4991c08 Compare

February 22, 2019 10:04

bmarty modified the milestones: Sprint 19, Sprint 20

BillCarsonFr added 5 commits

March 13, 2019 14:56


          Notification rework

62b744b

WIP of notification refactoring + upgrade


          Use automatic Parcelable

ec9f5f4


          basic smart reply support


          Handle serialization with serializable

80fdbb1


          cleanning

9a3d8f2

removed some logs

BillCarsonFr added 22 commits

March 13, 2019 14:56


          Extract data class in own files

6cfb5cf


          Remove dead code

060da6e


          Cleaning

692918c


          Fix / notifications always cleared

be1e5b3


          Notification action for invite

101df3a


          Fix / Potential smart reply in wrong room?

01fa41b

Ensure smart reply pending intent have unique action per room


          Fix / 'anonymous' message notif are still displayed after next sync

a9d581a

Push with with no data when background sync is off are displayed as simple anonymous notif. After a sync the event can be resolved, and is merged in a messaging style notif but the former simple notif was still on screen


          Fix / RoomName appears twice on some platform notifications templates

7aea566

+ cleaning


          Fix / Notif message style title/content for compat

f30862d

+ put summary line in resources
+ fix after restart sometimes only summary is shown


          Fix / Notif not cleared after tap on summary

e28cf6e


          Clean notification by removing read messages

533e0b4

Messages read on other device or web are now removed from notifications


          cleaning

9cac13a


          Cleaning and refactoring

2da027b


          Code review

6be1095

Code Review


          Fix / accept & reject notification intent

525a87d


          cleaning


          Remove LowDetail mode as it is not functionnal

af3e4c1

And do not ask battery optimisation for normal (not needed, Firebase high push will whitelist)


          Fix / Display content push even if room not known in store

69ff284

+ cleaning


          Removed unused i18n

72fea94


          Revert permission battery

416661d

cleaning


          resolve conflict on strings

d33c1a3


          Store notification events securely (encrypted)

63f4503

BillCarsonFr force-pushed the feature/notification_rework branch from f3490bc to 63f4503 Compare

March 13, 2019 14:04

BillCarsonFr and others added 2 commits

March 13, 2019 15:40


          Fix / unused translation

f684b74

+ </br> in contributing.md


          Improve "Notification privacy" setting screen

fdd5139

bmarty merged commit 409cf1e into develop

bmarty deleted the feature/notification_rework branch

March 18, 2019 09:39

bmarty mentioned this pull request

Sometimes every message causes a noisy notification #2420

Closed

lixmal mentioned this pull request

Fix LED not flashing on noisy message on some devices #3074

Closed

6 tasks

bmarty mentioned this pull request

Wear OS integration #2127

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature:notification