-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
EW: Modernize the recovery key input modal #29819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
uhoreg
merged 7 commits into
element-hq:develop
from
uhoreg:recovery_key_input_redesign
May 23, 2025
Merged
EW: Modernize the recovery key input modal #29819
uhoreg
merged 7 commits into
element-hq:develop
from
uhoreg:recovery_key_input_redesign
May 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a39416
to
d9d86ec
Compare
abccbb0
to
851f929
Compare
0ee21c0
to
6d02873
Compare
andybalaam
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Thank you! I am glad that this became just one input field, no matter if users have a generated key or a manually set phrase. Certainly prevents confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29228 (and #29120)
Designs
Checklist
public
/exported
symbols have accurate TSDoc documentation.