Skip to content

EW: Modernize the recovery key input modal #29819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2025

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Apr 25, 2025

Fixes #29228 (and #29120)

Designs

image

image

image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@uhoreg uhoreg force-pushed the recovery_key_input_redesign branch from 5a39416 to d9d86ec Compare May 17, 2025 11:59
@uhoreg uhoreg linked an issue May 22, 2025 that may be closed by this pull request
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@uhoreg uhoreg added this pull request to the merge queue May 23, 2025
Merged via the queue into element-hq:develop with commit 4518217 May 23, 2025
50 checks passed
@uhoreg uhoreg deleted the recovery_key_input_redesign branch May 23, 2025 21:19
@Croydon
Copy link

Croydon commented May 24, 2025

Thank you!

I am glad that this became just one input field, no matter if users have a generated key or a manually set phrase. Certainly prevents confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EW: Modernize the recovery key input modal "Reset security key" during login verification gets stuck in a loop
3 participants