Use React Suspense when rendering async modals - #28386
Merged
Merged
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
richvdh
reviewed
Nov 6, 2024
richvdh
left a comment
richvdh
left a comment
Member
There was a problem hiding this comment.
What's React Suspense? Why is it good, and what are the practical implications of it?
Member
Author
https://react.dev/reference/react/Suspense
Enables Concurrent Mode https://react.dev/blog/2022/03/29/react-v18#what-is-concurrent-react and what are the practical implications of it?
|
Member
|
I'm going to wait for review from a member of the web team before looking at this. If the web team is happy, I'll check the crypto bits. |
florianduros
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.