Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI frozen on "New login. Was this you?" pop up and later button also not working. #17667

Open
chagai95 opened this issue Jun 16, 2021 · 16 comments
Labels
A-E2EE-Cross-Signing A-Login A-Session-Mgmt Session / device names, management UI, etc. A-Toast O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Chronic Z-Community-Testing

Comments

@chagai95
Copy link
Contributor

Description

"New login. Was this you?" pop up does not go away without a refresh. later button just does not do anything and check your devices does not clear the pop up.

Here is a screen cap of this:

2021-06-16.10-24-10.mp4

Steps to reproduce

  • unknown

Logs being sent: yes

rageshake (3).zip

Version information

  • Platform: web (in-browser-pwa)
  • Browser: Chrome - the newest version: Version 91.0.4472.77 (Official Build) (64-bit)
  • OS: Windows
  • URL: anconnect.aarenet.com - develop branch
@SimonBrandner SimonBrandner added A-Login S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 16, 2021
@dbkr
Copy link
Member

dbkr commented Aug 17, 2021

I can't reproduce this, nor the dupes which say it's specific to when you log in and verify a device then try to dismiss the toast. The toast disappears automatically after I verify the new device.

@Biepa
Copy link

Biepa commented Sep 23, 2021

Just installed Element on Linux and added my phone. The overlay stays and even a restart of the program wont help.

@nielspeen
Copy link

Same issue with the Desktop app on Linux. I did find a work-around:

  • Open Settings > Preferences
  • Enable Display Communities instead of Spaces.
  • Close Settings. The pop-up will now disappear.
  • Open Settings > Preferences
  • Disable Display Communities instead of Space.
  • Close Settings. The pop-up is still gone.

@dbkr
Copy link
Member

dbkr commented Oct 13, 2021

One cause of this could be clicking the button before the app has completed its initial sync, in which case it will be ignored. I'm not convinced this is the only cause though: in the video above it looks like the app has finished syncing.

@novocaine
Copy link
Contributor

novocaine commented Oct 21, 2021

I just experienced this; nightly desktop

@jaller94
Copy link
Contributor

jaller94 commented Nov 9, 2021

I got this on a very old Element Web 1.9.4 session.

  1. Log into another Element Web. (same browser, different domain)
  2. Verify by using emoji.
  3. "New login. Was this you? (2/3)" is there forever now.

Clicking on "Check your devices"

Opens the Settings modal but closing the modal does not progress the toast.

Clicking on "Later"

Does nothing in the UI. Prints these JavaScript messages:

Dismissing unverified sessions: SRGTZWIGZY
Old unverified sessions:
New unverified sessions: 

@novocaine novocaine added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 19, 2021
@novocaine
Copy link
Contributor

Promoting Occurence due to number of reports

@andybalaam
Copy link
Contributor

I got this today. Rageshake attached to #19930

@Linerly
Copy link
Contributor

Linerly commented Dec 10, 2021

This always happen to me when I verify a new session

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Dec 16, 2021

Happened to me on develop. today, version and logs here;

Element version: 23b21c940c68-react-9a8265429c16-js-3eaed304466a Olm version: 3.2.8 on matrix.org

image

This happens directly after pressing the "later" button.

This clears when you reload the tab.


Note that, this was verifying B from A, when i later on verified C from B, i could normally click it away from A, though at the same time i couldn't click it away on B.

@KM217
Copy link

KM217 commented Dec 31, 2021

I just had the same thing happen to me.
Installed and authenticated on Element 1.9.8 running on Fedora 35.
Authenticated on the mobile app on my Android smartphone running Element 1.3.12
After I completed all of device verification steps, scaned the QR code, etc., the toast appeared and, due to the strange letter combination, I went ahead and clicked [Check your devices]. The settings window appeared, I edited the name of the mobile device, and I saved it. I then closed the settings window, but the toast popup was still there. I tried clicking [Later] several times, but it did not work. I attempted to click [Check your devices] and it was still functional. I tried clicking [Later] again and it did nothing.

Also, the text in the [Later] button is highlightable with the mouse. I do not know if that was a design decision of an indicator of the potential cause of this bug.
Screenshot from 2021-12-30 21-11-16

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Feb 1, 2022

Reproduced this today. Rageshake: https://github.com/matrix-org/element-web-rageshakes/issues/10306

Happened after clicking "Later" on the 8/12 unverified sessions.

@dbkr
Copy link
Member

dbkr commented Mar 2, 2022

Thanks for the debug logs. I've added some more logging, so if anyone sees this again, please rageshake again.

@MadLittleMods
Copy link
Contributor

@dbkr New rageshake logs available at https://github.com/matrix-org/element-web-rageshakes/issues/12252 and I see your new logging lines 😇 Any insight?

@bmarty
Copy link
Member

bmarty commented May 17, 2023

I have repro this issue today, but cannot repro anymore.

The popup "Was this you?" was displayed, I did not closed it, then I verified the session between Web and Android, and at the end I was not able to close this popup:

image

Notice the "Verified" status of the session. I guess the popup should auto-close in this case, (session is verified: so it was me), and this is what's happenning when I tried to repro, but probably some race condition prevent this and the popup becomes inactive.

Also: the account is pretty large (about 600 rooms), and the init sync on mobile takes about 30s.

@rwmjones
Copy link

rwmjones commented Jun 15, 2023

I've had this pop-over appearing for like 12 months and could never work out how to get rid of it. Please add a "go away" button to the dialog. It's impossible for me to complete the verification as it was some browser login and I've long since cleared the cookies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing A-Login A-Session-Mgmt Session / device names, management UI, etc. A-Toast O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Chronic Z-Community-Testing
Projects
None yet
Development

No branches or pull requests