-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update nuget to v6.10.1 #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case anyone wants a 2nd opinion, I did double-check to confirm that the nuget executable in 281aa14 is identical to the one at https://dist.nuget.org/win-x86-commandline/latest/nuget.exe 👍
@ckerr Could you help merge it? |
@beyondkmp I'd like at least one other person from @electron/wg-ecosystem to TAL too; but yeah, it's been two weeks. If nobody else reviews I'm 👍 on this PR |
@ckerr, I believe the decision during the last Ecosystem WG meeting was to merge #526 to provide the escape hatch mechanism, but otherwise close these individual upgrades to NuGet and 7Zip, see Felix's comment here: #526 (review). Unfortunately this project is lightly maintained at the moment and we don't feel confident in updating these without more due diligence than we currently have bandwidth for. As such I'm going to close this PR, but we will hopefully revisit it in the future. |
Some insight to bring up at your next discussion. Updating NuGet also fixes a variety of errors too -- see discussion on PR #495. These aren't particularly easy issues to debug and I have doubts that even intermediate programmers will find and use the undocumented escape hatch. I can only imagine using a 10yr old binary is going to cause even more bugs and issues for this under-staffed effort in the future anyways. Perhaps worth re-consideration, I'm happy to help with the effort where I can. |
The current version of NuGet causes the CPU usage to be nearly 100% and the memory usage to be very high, almost 2GB during packaging.
The latest version of NuGet only uses about 600MB of memory.
The nuget downloads from https://dist.nuget.org/win-x86-commandline/latest/nuget.exe
md5: 6b260d67fc4f18048347ae3c0d8e59bf