Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update nuget to v6.10.1 #525

Closed
wants to merge 1 commit into from
Closed

Conversation

beyondkmp
Copy link
Contributor

@beyondkmp beyondkmp commented Jul 20, 2024

The current version of NuGet causes the CPU usage to be nearly 100% and the memory usage to be very high, almost 2GB during packaging.

Mem:           1.8Gi       1.7Gi        65Mi       2.0Mi       212Mi       114Mi
Swap:          2.0Gi        39Mi       2.0Gi

The latest version of NuGet only uses about 600MB of memory.

               total        used        free      shared  buff/cache   available
Mem:           1.8Gi       594Mi        61Mi       2.1Mi       1.3Gi       1.2Gi
Swap:             0B          0B          0B

The nuget downloads from https://dist.nuget.org/win-x86-commandline/latest/nuget.exe
md5: 6b260d67fc4f18048347ae3c0d8e59bf

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case anyone wants a 2nd opinion, I did double-check to confirm that the nuget executable in 281aa14 is identical to the one at https://dist.nuget.org/win-x86-commandline/latest/nuget.exe 👍

@beyondkmp
Copy link
Contributor Author

@ckerr Could you help merge it?

@ckerr ckerr requested a review from a team August 2, 2024 14:00
@ckerr
Copy link
Member

ckerr commented Aug 2, 2024

@beyondkmp I'd like at least one other person from @electron/wg-ecosystem to TAL too; but yeah, it's been two weeks. If nobody else reviews I'm 👍 on this PR

@dsanders11
Copy link
Member

@ckerr, I believe the decision during the last Ecosystem WG meeting was to merge #526 to provide the escape hatch mechanism, but otherwise close these individual upgrades to NuGet and 7Zip, see Felix's comment here: #526 (review).

Unfortunately this project is lightly maintained at the moment and we don't feel confident in updating these without more due diligence than we currently have bandwidth for. As such I'm going to close this PR, but we will hopefully revisit it in the future.

@Bug-Reaper
Copy link

@ckerr, I believe the decision during the last Ecosystem WG meeting was to merge #526 to provide the escape hatch mechanism, but otherwise close these individual upgrades to NuGet and 7Zip, see Felix's comment here: #526 (review).

Unfortunately this project is lightly maintained at the moment and we don't feel confident in updating these without more due diligence than we currently have bandwidth for. As such I'm going to close this PR, but we will hopefully revisit it in the future.

@dsanders11

Some insight to bring up at your next discussion. Updating NuGet also fixes a variety of errors too -- see discussion on PR #495. These aren't particularly easy issues to debug and I have doubts that even intermediate programmers will find and use the undocumented escape hatch.

I can only imagine using a 10yr old binary is going to cause even more bugs and issues for this under-staffed effort in the future anyways.

Perhaps worth re-consideration, I'm happy to help with the effort where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants