Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use electron-winstaller instead of self module #8344

Merged
merged 74 commits into from
Feb 3, 2025

Conversation

beyondkmp
Copy link
Collaborator

@beyondkmp beyondkmp commented Jul 17, 2024

  1. Add customSquirrelExePath option, which allows using custom squirrel windows
  2. Use official electron-winstaller
  3. Support Windows ARM
  4. Fix some bugs([Security] Hijacking DLL problem electron-builder-binaries#33, Squirrel.Windows does not support ARM64 electron-builder-binaries#52)

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 11f53ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
electron-builder-squirrel-windows Patch
dmg-builder Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Stanzilla
Copy link

Is this package actually still supported by the electron team? Many packages in that org have been dead for a long time.

@mmaietta
Copy link
Collaborator

Is this package actually still supported by the electron team? Many packages in that org have been dead for a long time.

That's a great point. @beyondkmp what bug fixes is this solving for? (Can't tell from the description)

@mmaietta
Copy link
Collaborator

@Stanzilla looks like updates are still being pushed to electron-winstaller, last update was 3mo ago. https://www.npmjs.com/package/electron-winstaller

@beyondkmp
Copy link
Collaborator Author

@mmaietta Resolved the code conflict now, but this UT keeps failing, running locally is no problem. It looks like there is a problem with this UT on the master, help me out if you have time.
image

@mmaietta
Copy link
Collaborator

I'll take a look at this today. There is no problem on master though...as the commit test history is clean: https://github.com/electron-userland/electron-builder/commits/master/

@mmaietta
Copy link
Collaborator

I pushed your branch to origin/win-installer within the electron-builder repo and the tests all pass correctly: https://github.com/electron-userland/electron-builder/actions/runs/13076539224

My best guess is that running the job from your fork is not able to access that repo secret specifically?

@beyondkmp
Copy link
Collaborator Author

@mmaietta Yes, that's correct. The reason is the same as what you mentioned. The conflicts in this MR have been resolved. When you have time, please help review it again. If there are no issues, it can be merged.

@mmaietta mmaietta removed the Stale label Feb 3, 2025
@beyondkmp beyondkmp requested a review from mmaietta February 3, 2025 06:26
mmaietta
mmaietta previously approved these changes Feb 3, 2025
Copy link
Collaborator

@mmaietta mmaietta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants