-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use electron-winstaller instead of self module #8344
Conversation
🦋 Changeset detectedLatest commit: 11f53ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Is this package actually still supported by the electron team? Many packages in that org have been dead for a long time. |
That's a great point. @beyondkmp what bug fixes is this solving for? (Can't tell from the description) |
@Stanzilla looks like updates are still being pushed to |
@mmaietta Resolved the code conflict now, but this UT keeps failing, running locally is no problem. It looks like there is a problem with this UT on the master, help me out if you have time. |
I'll take a look at this today. There is no problem on |
I pushed your branch to My best guess is that running the job from your fork is not able to access that repo secret specifically? |
@mmaietta Yes, that's correct. The reason is the same as what you mentioned. The conflicts in this MR have been resolved. When you have time, please help review it again. If there are no issues, it can be merged. |
packages/electron-builder-squirrel-windows/src/SquirrelWindowsTarget.ts
Outdated
Show resolved
Hide resolved
packages/electron-builder-squirrel-windows/src/SquirrelWindowsTarget.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
customSquirrelExePath
option, which allows using custom squirrel windows