Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme #98

Merged
merged 1 commit into from
Dec 21, 2015
Merged

update readme #98

merged 1 commit into from
Dec 21, 2015

Conversation

tborychowski
Copy link
Contributor

  • update confusing description:
    • from: pack to run electron-builder and build to use electron-packager
    • to: pack to run electron-packager and build to use electron-builder
  • update packager.json to builder.json
  • update electron version to v0.36.1 in the example commands
  • update code highlighting for json examples from js to json
    ref: confusing readme #96

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @stefanjudis, @radibit and @freewil to be potential reviewers

@stefanjudis
Copy link
Contributor

Cool stuff! Thanks. I'm planning to have another minor release today! 👍 :bowtie:

@stefanjudis stefanjudis self-assigned this Dec 21, 2015
@stefanjudis stefanjudis added this to the v2.4.0 milestone Dec 21, 2015
stefanjudis added a commit that referenced this pull request Dec 21, 2015
@stefanjudis
Merge pull request #98 from tborychowski/patch-1
74078fa 
update readme
@stefanjudis stefanjudis merged commit 74078fa into electron-userland:master Dec 21, 2015
@stefanjudis stefanjudis mentioned this pull request Dec 21, 2015
Closed
@stefanjudis stefanjudis modified the milestones: v2.5.0, v2.4.0 Dec 21, 2015
@mweibel mweibel mentioned this pull request Jan 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stefanjudis stefanjudis

Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tborychowski @mention-bot @stefanjudis