package.json: scripts - infinite loop?

[mweibel]

I was reading through the readme and I think there's some stuff off with the scripts in the "How we use it" section.

"pack": "npm run clean && npm run build:osx && npm run build:win",
"pack:osx": "npm run clean:osx && electron-packager ./app \"Loopline Systems\" --out=dist/osx --platform=darwin --arch=x64 --version=0.36.1 --icon=assets/osx/loopline.icns",
"pack:win": "npm run clean:win && electron-packager ./app \"Loopline Systems\" --out=dist/win --platform=win32 --arch=ia32 --version=0.36.1 --icon=assets/win/icon.ico",

"build": "npm run pack:osx && npm run pack:win",
"build:osx": "npm run build:osx && electron-builder \"dist/osx/Loopline Systems.app\" --platform=osx --out=\"dist/osx\" --config=builder.json",
"build:win": "npm run build:win && electron-builder \"dist/win/Loopline Systems-win32\" --platform=win --out=\"dist/win\" --config=builder.json"

• build:osx runs build:osx again?
• pack runs build:*, shouldn't this run both packs?
• same for build, build runs pack?

I'll be happy to provide a PR if my assumptions are correct that this is wrong.
I'd change it to that:

"pack": "npm run clean && npm run pack:osx && npm run pack:win",
"pack:osx": "npm run clean:osx && electron-packager ./app \"Loopline Systems\" --out=dist/osx --platform=darwin --arch=x64 --version=0.36.1 --icon=assets/osx/loopline.icns",
"pack:win": "npm run clean:win && electron-packager ./app \"Loopline Systems\" --out=dist/win --platform=win32 --arch=ia32 --version=0.36.1 --icon=assets/win/icon.ico",

"build": "npm run build:osx && npm run build:win",
"build:osx": "npm run pack:osx && electron-builder \"dist/osx/Loopline Systems.app\" --platform=osx --out=\"dist/osx\" --config=builder.json",
"build:win": "npm run pack:win && electron-builder \"dist/win/Loopline Systems-win32\" --platform=win --out=\"dist/win\" --config=builder.json"

Also should pack run build first?

related: #98

[stefanjudis]

You're absolutely right!!!

Clean -> Pack -> Build.

Thanks for pointing that out. :) A PR would be awesome.

[stefanjudis]

@mweibel had a bit of time. Thanks for pointing it out. :)

[mweibel]

awesome, thanks @stefanjudis!