Skip to content

Commit

Permalink
fix(windows): detect node path correctly on windows with cross-spawn (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
Losses authored Aug 22, 2021
1 parent 695f89a commit 6c945bd
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/long-jeans-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"builder-util": patch
---

fix(windows): detect node path correctly on windows with cross-spawn (#6069)
2 changes: 2 additions & 0 deletions packages/builder-util/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"bluebird-lst": "^1.0.9",
"builder-util-runtime": "workspace:*",
"chalk": "^4.1.1",
"cross-spawn": "^7.0.3",
"debug": "^4.3.2",
"fs-extra": "^10.0.0",
"is-ci": "^3.0.0",
Expand All @@ -32,6 +33,7 @@
},
"typings": "./out/util.d.ts",
"devDependencies": {
"@types/cross-spawn": "^6.0.2",
"@types/is-ci": "3.0.0",
"@types/js-yaml": "4.0.2",
"@types/source-map-support": "0.5.4"
Expand Down
3 changes: 2 additions & 1 deletion packages/builder-util/src/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { path7za } from "7zip-bin"
import { appBuilderPath } from "app-builder-bin"
import { safeStringifyJson } from "builder-util-runtime"
import * as chalk from "chalk"
import { ChildProcess, execFile, ExecFileOptions, spawn as _spawn, SpawnOptions } from "child_process"
import { ChildProcess, execFile, ExecFileOptions, SpawnOptions } from "child_process"
import { spawn as _spawn } from "cross-spawn"
import { createHash } from "crypto"
import _debug from "debug"
import { dump } from "js-yaml"
Expand Down
10 changes: 10 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6c945bd

Please sign in to comment.