-
Notifications
You must be signed in to change notification settings - Fork 295
ci: Build Docker Hub images using GitHub Actions #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
c5fbc9d to
cb04090
Compare
cb04090 to
f3d6cd7
Compare
10 tasks
robacourt
approved these changes
Dec 17, 2025
Contributor
robacourt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces our Buildkite pipeline on GitHub Actions and allows us to retire Buildkite.
The most painful problem that this solves are the missing webhooks that result in missed release images on Docker Hub. In a few words, when we push a release commit to
mainthat touches 4 or more components, and so the commit itself gets 4+ tags, GitHub does not send a webhook to Buildkite because of its limit on max tags. In such cases, we always had to manually force-push only the@core/sync-service:...tag to trigger a Buildkite pipeline.The GitHub Actions workflow implemented here is verbose because it has to orchestrate a single shared step, followed by a matrix that uses a separate runner for building different platforms, followed by another shared step that collects the digests from the matrix and combines them into a single multi-arch tagged image on Docker Hub.
It may be possible to simplify it later on, since our next target is migrating some or all of our runners to Blacksmith, and Blacksmith promises to implement implicit forking of Docker builder into different runners based on the passed platforms, kinda like Buildkite has been doing.
Closes #3607.