Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync-service): Clean up publication filters #2154

Merged
merged 24 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix passing as function
  • Loading branch information
msfstef committed Dec 16, 2024
commit 886cc6ace5ccb35e9ee88049bc8eab98c64fa4ba
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ defmodule Electric.Postgres.Configuration do
@doc """
Get Postgres server version
"""
@spec get_pg_version(Postgrex.conn()) :: integer
@spec get_pg_version(Postgrex.conn()) :: non_neg_integer()
def get_pg_version(conn) do
case Postgrex.query(
conn,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ defmodule Electric.Replication.PublicationManager do
Configuration.configure_tables_for_replication!(
db_pool,
Map.values(relation_filters),
fn -> pg_version end,
pg_version,
publication_name
)

Expand Down
3 changes: 1 addition & 2 deletions packages/sync-service/test/support/component_setup.ex
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ defmodule Support.ComponentSetup do
name: server,
stack_id: ctx.stack_id,
publication_name: ctx.publication_name,
db_pool: ctx.pool,
pg_version: Application.fetch_env!(:electric, :pg_version_for_tests)
db_pool: ctx.pool
)

%{
Expand Down