-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync-service): Clean up publication filters #2154
Conversation
eb3a49c
to
be3538e
Compare
Regarding #1831 - we need to figure out when we need Once we determine if we can afford not to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
benchmark this |
f8edde4
to
64729a4
Compare
5105ced
to
6e1aeca
Compare
6e1aeca
to
d0f488c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, and good tests. Coupld of nitpicks but feel free to ignore
d0f488c
to
5e5531a
Compare
benchmark this |
Closes #1774
This work started to introduce column filters (see #1831) but ended up on a road block because of us using
REPLICA IDENTITY FULL
- however the work also takes care of cleaning up filters.remove_shape
call so that if electric remains with no shapes it should also have no subscriptions to tables.TODOs
PublicationManager
shape_status.list_shapes
inrecover_shapes
AND
s to improve filter optimality (suggested be @icehaunter ) - [edit: not doing this now, as we can be smart about this an do even more "merging" of where clauses likex = 1
andx = 2
tox in (1, 2)
- separate PR]