Introduce Elastio Connector Terraform Module#94
Merged
Conversation
Veetaha
force-pushed
the
feat/connector-terraform
branch
from
783e799 to
2c6557f
Compare
babinskiy
reviewed
Mar 21, 2025
.githooks/pre-commit
Outdated
|
|
||
| script_dir=$(dirname "$(readlink -f "${BASH_SOURCE[0]}")") | ||
|
|
||
| tf_modules=$("$script_dir/../scripts/collect-modules.sh") |
Contributor
There was a problem hiding this comment.
I would put the CI-related scripts in the .github/scripts,
and keep ./scripts is for customer-used scripts
Contributor
Author
There was a problem hiding this comment.
Sure, moved the script
Veetaha
force-pushed
the
feat/connector-terraform
branch
from
d4de113 to
178d44b
Compare
babinskiy
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the Elastio Connector deployment terraform module from
elastio/contribto this repository.I've also split that module into 4 to allow for finger-grained control over the deployment:
elasito-connector- an all-in-one module that deploys the 3 other modules belowelastio-connector-account- a thin wrapper over the Elastio Connector Account CFN stackelasito-connector-region- a thin wrapper over the HTTP REST API of Elastio Portal to initiate the Elastio Connector Region stack deploymentelastio-nat-provision- a thin wrapper over theelastio-nat-provision-lambdaCFN stack for dynamic management of NAT getaways