Skip to content

Add network configuration CFN param#113

Closed
mhnap wants to merge 1 commit intomasterfrom
feat/9913
Closed

Add network configuration CFN param#113
mhnap wants to merge 1 commit intomasterfrom
feat/9913

Conversation

@mhnap
Copy link

@mhnap mhnap commented Jan 29, 2025

No description provided.

@mhnap mhnap requested a review from Veetaha January 29, 2025 17:03
@mhnap mhnap removed the request for review from Veetaha January 29, 2025 17:27
@mhnap mhnap requested a review from Veetaha January 29, 2025 18:12
Comment on lines 162 to 163
{ account_id = data.aws_caller_identity.current.account_id,
network_configuration = var.network_configuration },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ account_id = data.aws_caller_identity.current.account_id,
network_configuration = var.network_configuration },
{
account_id = data.aws_caller_identity.current.account_id,
network_configuration = var.network_configuration
},

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Veetaha
Copy link
Contributor

Veetaha commented Mar 21, 2025

This stack was moved to elastio-stack repo. I moved the code changes from this PR into that repo elastio/elastio-stack#94. Closing this PR

@Veetaha Veetaha closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants