Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test package for dataset_is_prefix flag. #676

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Add test package for dataset_is_prefix flag. #676

merged 2 commits into from
Jan 27, 2021

Conversation

skh
Copy link
Contributor

@skh skh commented Jan 26, 2021

This adds a test package for the change in #674

@skh skh requested a review from ruflin January 26, 2021 15:25
@skh skh mentioned this pull request Jan 26, 2021
Merged
@elasticmachine
Copy link

elasticmachine commented Jan 26, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #676 updated

    • Start Time: 2021-01-26T16:57:50.712+0000

  • Duration: 7 min 5 sec

  • Commit: eef34b2

Test stats 🧪

Test Results
Failed 0
Passed 171
Skipped 0
Total 171

@skh
Copy link
Contributor Author

skh commented Jan 26, 2021

@ycombinator Does this need a changelog entry?

@ycombinator
Copy link
Contributor

@skh I don't think so, since it's not a user-impacting change.

@skh skh force-pushed the add-testpackage-dataset-is-prefix branch from ac7d72e to eef34b2 Compare January 26, 2021 16:57
ruflin
ruflin approved these changes Jan 27, 2021
View reviewed changes
testdata/generated/package/dataset_is_prefix/0.0.1/index.json
{
"type": "metrics",
"dataset": "dataset_is_prefix.test",
"dataset_is_prefix": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skh skh merged commit 17abc9a into elastic:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skh @elasticmachine @ycombinator @ruflin