Add "dataset_is_prefix" field to data_stream, if present. #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skh
force-pushed
the
add-dataset-is-prefix
branch
from
14e1c8c
to
be4bf15
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
|
Hi @skh, could you try running |
ycombinator
requested changes
Jan 26, 2021
There was a problem hiding this comment.
Could you add a CHANGELOG entry for this change, please? Thanks!
https://github.com/elastic/package-registry/blob/master/CHANGELOG.md
|
Would be nice to have a follow up adding this to one of the test packages: https://github.com/elastic/package-registry/tree/master/testdata/package Then we can see how the actual output looks. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the new field
dataset_is_prefixso that it can be used by Kibana/EPM.The field was added to package-spec in elastic/package-spec#102