Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add traces as valid type #656

Merged
merged 5 commits into from
Nov 20, 2020
Merged

Add traces as valid type #656

merged 5 commits into from
Nov 20, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Nov 20, 2020

@elasticmachine
Copy link

elasticmachine commented Nov 20, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #656 updated]

  • Start Time: 2020-11-20T13:49:50.161+0000

  • Duration: 7 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 163
Skipped 0
Total 163

ruflin
ruflin reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, could you add a changelog entry?

Would be good if @ycombinator or @mtojek could also have a look.

mtojek
mtojek reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a new test package with relevant data stream to the testdata/package directory? You can test it with go test .. You will also need to regenerate expected data with go test . -generate.

@mtojek
Copy link
Contributor

mtojek commented Nov 20, 2020

As @ruflin has already mentioned, please add a CHANGELOG.

@mtojek mtojek self-requested a review November 20, 2020 13:52
mtojek
mtojek approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Free free to merge it if the CI build goes green.

@jalvz jalvz merged commit 19b4ca9 into elastic:master Nov 20, 2020
@jalvz jalvz mentioned this pull request Nov 23, 2020
Closed
15 tasks
@jalvz jalvz mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin left review comments

@mtojek mtojek mtojek approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jalvz @elasticmachine @mtojek @ruflin