Add data stream type "traces". #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
|
ruflin
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
LGTM.
@ycombinator Could you check if this is the only place it needs to be added?
|
@ycombinator does this looks good to you? |
ycombinator
reviewed
Nov 9, 2020
| @@ -5,10 +5,13 @@ | |||
| changes: | |||
| - description: Initial version of the Elastic Package specifiction. | |||
| type: enhancement | |||
| link: https://github.com/elastic/package-spec/pulls/1 | |||
| link: https://github.com/elastic/package-spec/pull/1 | |||
There was a problem hiding this comment.
Thanks for fixing this. <3
ycombinator
approved these changes
Nov 9, 2020
This was referenced Jan 15, 2021
rw-access
pushed a commit
to rw-access/package-spec
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68