Skip to content

[ML] Updates to STYLEGUIDE.md about explicit "if" statements. #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2019
Merged

[ML] Updates to STYLEGUIDE.md about explicit "if" statements. #862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion STYLEGUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ The use of the words SHOULD, MUST etc., comply with RFC 2119.
Reference | Calling function
Const reference | Calling function

1. Explicit integer definitions, specifying size, SHOULD be used
1. `if` statements SHOULD be fully qualified. The exception is where it is clear that a boolean expression is being tested.
1. Explicit integer definitions, specifying size, SHOULD be used
1. Member functions MUST be scoped with `this->` when called
1. Floating point variables SHOULD be `double`
1. Lambdas SHOULD be used in preference to any form of `bind`
Expand Down