Skip to content

[ML] Updates to STYLEGUIDE.md about explicit "if" statements. #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

edsavage
Copy link
Contributor

c.f. comments in #861

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsavage
Copy link
Contributor Author

edsavage commented Nov 29, 2019

Merging now as this change is only to documentation.

Plans are afoot to be able to skip the CI build for PRs labelled <docs.

@edsavage edsavage merged commit f030a50 into elastic:master Nov 29, 2019
@edsavage edsavage deleted the styleguide branch November 29, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants