Skip to content

[ML] Use gcc 10.3 Docker image for Jupyter Dockerfile #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 20, 2021
Merged

[ML] Use gcc 10.3 Docker image for Jupyter Dockerfile #2032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c216249
[ML] Use gcc 10.3 Docker image for Jupyter Dockerfile
droberts195 Sep 20, 2021
0545b3e
Fix formatting
droberts195 Sep 20, 2021
82c3a73
Merge branch 'main' into upgrade-gcc-for-incremental-training
droberts195 Sep 20, 2021
ba16655
Merge branch 'feature/incremental-learning' into upgrade-gcc-for-incr…
droberts195 Sep 20, 2021
3d3db61
Adjust test threshold
droberts195 Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jupyter/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# compliance with the Elastic License 2.0 and the foregoing additional
# limitation.

FROM docker.elastic.co/ml-dev/ml-linux-build:17 as builder
FROM docker.elastic.co/ml-dev/ml-linux-build:19 as builder

RUN yum install -y epel-release && \
yum install -y ccache
Expand Down
2 changes: 1 addition & 1 deletion lib/maths/CBoostedTreeLeafNodeStatistics.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

#include <maths/CBoostedTreeLeafNodeStatistics.h>

#include <core/CMemory.h>
#include <core/CDataFrame.h>
#include <core/CLogger.h>
#include <core/CMemory.h>

#include <maths/CBoostedTree.h>
#include <maths/CDataFrameCategoryEncoder.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/maths/unittest/CDataFrameUtilsTest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,7 +1490,7 @@ BOOST_AUTO_TEST_CASE(testMaximumMinimumRecallClassWeights) {
LOG_DEBUG(<< "max recalls = " << core::CContainerPrinter::print(maxRecalls));

// Threaded and non-threaded results are close.
BOOST_REQUIRE_CLOSE(minRecalls[0][0], minRecalls[1][0], 1.0); // 1 %
BOOST_REQUIRE_CLOSE(minRecalls[0][0], minRecalls[1][0], 1.5); // 1.5 %

// We improved the minimum class recall by at least 10%.
BOOST_TEST_REQUIRE(minRecalls[0][0] > 1.1 * minRecalls[0][1]);
Expand Down