Skip to content

[ML] Use gcc 10.3 Docker image for Jupyter Dockerfile #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

droberts195
Copy link
Contributor

The base image needs to match what the source code
expects, which is version 19 since #2028 was merged.

The base image needs to match what the source code
expects, which is version 19 since elastic#2028 was merged.
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195
Copy link
Contributor Author

The test failure that led to the test threshold change in 3d3db61 was:

[Exception] - difference{0.0119332} between minRecalls[0][0]{0.85760517799352753} and minRecalls[1][0]{0.84749190938511332} exceeds 1%
 == [File] - CDataFrameUtilsTest.cc
 == [Line] -1493

@tveasey and @valeriy42 the threshold increase is pretty small so I don't think it's a problem but just wanted to flag it for you. I imagine there's some performance improvement in gcc 10.3 that leads to single-threaded and multi-threaded diverging slightly more.

@droberts195
Copy link
Contributor Author

The latest test failure is detailed in #2033. I don't think that's a problem that's been introduced by this PR - it seems to have wider implications for test reproducibility - so I'll merge as-is and leave #2033 to be investigated separately.

@droberts195 droberts195 merged commit 258d509 into elastic:feature/incremental-learning Sep 20, 2021
@droberts195 droberts195 deleted the upgrade-gcc-for-incremental-training branch September 20, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants