Revert "Fix: cloud_id not propagating from monitoring config" #11828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 76dc55f. The reason for this revert is that the fix will be implemented by having the ES output set up credentials/hosts and cloud.id during build_client method. With this there will be no need for changing code on the Logstash core side. We will later reintroduce the spec part of this commit.
colinsurprenant
requested review from
kares and
colinsurprenant
and removed request for
kares
|
This will replace #11818 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 76dc55f in the 7.7 branch
The reason for this revert is that the fix will be implemented by
having the ES output set up credentials/hosts and cloud.id during
build_client method. With this there will be no need for changing
code on the Logstash core side.
We will later reintroduce the spec part of this commit.