remove plugin internal validation call #11818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this. Starting to look 🏖️ again! |
|
This will be merged in 7.6, 7.x and master. |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 23, 2020
elasticsearch-bot
pushed a commit
that referenced
this pull request
Apr 23, 2020
|
Merged in 7.6, 7.x, master. |
colinsurprenant
added a commit
to colinsurprenant/logstash
that referenced
this pull request
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of #11800 to avoid calling plugin internals. Instead the plugin validation steps have been move into the
build_clientmethod per logstash-plugins/logstash-output-elasticsearch#934See logstash-plugins/logstash-output-elasticsearch#934 (review) for more details.
Note This PR will fail until logstash-plugins/logstash-output-elasticsearch#934 is pushed and we wire the dependency to that new plugin version.
/cc @kares