Move more Kibana packages to UI shared deps #95894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
v8.0.0
release_note:skip
spalger
reviewed
Mar 31, 2021
jbudz
approved these changes
Mar 31, 2021
mshustov
added
the
auto-backport
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groups@kbn/ui-shared-deps asset size
async chunk count
History
To update your PR or re-run it, just comment with: |
Contributor
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually run: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Mar 31, 2021
* move @kbn/std to kbn-ui-shared-deps * add @elastic/safer-lodash-set to kbn-ui-shared-deps * update limits * Revert "update limits" This reverts commit f396d47. * decrase limits for Core team owned code # Conflicts: # packages/kbn-optimizer/limits.yml
mshustov
added a commit
that referenced
this pull request
Mar 31, 2021
* move @kbn/std to kbn-ui-shared-deps * add @elastic/safer-lodash-set to kbn-ui-shared-deps * update limits * Revert "update limits" This reverts commit f396d47. * decrase limits for Core team owned code # Conflicts: # packages/kbn-optimizer/limits.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
@kbn/stdand@elastic/safer-lodash-setto shared deps to avoid copying them to every plugin bundle.@elastic/kibana-operations I had to cleanp
limits.ymlfile content to makenode scripts/build_kibana_platform_plugins --update-limitsto update it