Migrate away from legacyEs service in tests.
#95402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
release_note:skip
azasypkin
commented
Mar 25, 2021
| expect(containsSpace2).to.eql(false); | ||
| }); | ||
| const space2OnlyObjExists = docs.some((x) => x._id === CASES.SPACE_2_ONLY); | ||
| const space2OnlyObjExists = docs.some((x) => x._id === CASES.SPACE_2_ONLY.id); |
Member
Author
There was a problem hiding this comment.
note: if tests pass with this change then it's probably not used at all....
Member
There was a problem hiding this comment.
It's hard to prove a negative :). I think we should adjust the query above on line 146 to have add the size parameter, so that we at least attempt to retrieve more than 10 objects. ES won't retrieve more than 10 without that parameter set
Member
Author
There was a problem hiding this comment.
Let me try to make this adjustment then.
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
azasypkin
added
the
auto-backport
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 26, 2021
Contributor
74 tasks
kibanamachine
added a commit
that referenced
this pull request
Mar 26, 2021
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were a number tests we own that still used legacy ES client. In this PR I migrate these tests to a new client.
Related to: #83910