Skip to content

Commit 04413a3

Browse files
committed
Review#1: adjust test to make it more useful.
1 parent 584b4f5 commit 04413a3

File tree

1 file changed

+4
-2
lines changed
  • x-pack/test/spaces_api_integration/common/suites

1 file changed

+4
-2
lines changed

x-pack/test/spaces_api_integration/common/suites/delete.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,15 +138,17 @@ export function deleteTestSuiteFactory(
138138

139139
expect(buckets).to.eql(expectedBuckets);
140140

141-
// There were eleven multi-namespace objects.
141+
// There were 15 multi-namespace objects.
142142
// Since Space 2 was deleted, any multi-namespace objects that existed in that space
143143
// are updated to remove it, and of those, any that don't exist in any space are deleted.
144144
const { body: multiNamespaceResponse } = await es.search<Record<string, any>>({
145145
index: '.kibana',
146+
size: 20,
146147
body: { query: { terms: { type: ['sharedtype'] } } },
147148
});
148149
const docs = multiNamespaceResponse.hits.hits;
149-
expect(docs).length(10); // just ten results, since spaces_2_only got deleted
150+
// Just 12 results, since spaces_2_only, conflict_1_space_2 and conflict_2_space_2 got deleted.
151+
expect(docs).length(12);
150152
docs.forEach((doc) => () => {
151153
const containsSpace2 = doc?._source?.namespaces.includes('space_2');
152154
expect(containsSpace2).to.eql(false);

0 commit comments

Comments
 (0)