[kbn/optimizer][ci-stats] ship metrics separate from build #90482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data rather than fs
…arate-report-tasks
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
This comment has been minimized.
This comment has been minimized.
Member
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Feb 8, 2021
spalger
added a commit
that referenced
this pull request
Feb 8, 2021
) (#90659) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than shipping metrics to ci-stats during the build, this PR writes the metrics to the filesystem so that it can be cached, and then shipped to ci-stats as a separate step so that we can work on caching the build step with bazel.
metrics.jsonfiles in each bundle from the optimizertarget/optimizer_bundle_metrics.jsonafter running the optimizer in the buildBuildKibanaPlatformPluginstask of the build scriptnode scripts/ship_ci_stats --metrics target/optimizer_bundle_metrics.jsonafter runningnode scripts/buildin the places where we want metrics.