Skip to content

Commit b722e38

Browse files
committed
inline getMetrics logic which isn't shared anymore
1 parent 6645d0c commit b722e38

File tree

3 files changed

+10
-26
lines changed

3 files changed

+10
-26
lines changed

packages/kbn-optimizer/src/limits.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,13 @@
77
*/
88

99
import Fs from 'fs';
10+
import Path from 'path';
1011

1112
import dedent from 'dedent';
1213
import Yaml from 'js-yaml';
13-
import { createFailError, ToolingLog } from '@kbn/dev-utils';
14+
import { createFailError, ToolingLog, CiStatsMetrics } from '@kbn/dev-utils';
1415

15-
import { OptimizerConfig, getMetrics, Limits } from './optimizer';
16+
import { OptimizerConfig, Limits } from './optimizer';
1617

1718
const LIMITS_PATH = require.resolve('../limits.yml');
1819
const DEFAULT_BUDGET = 15000;
@@ -76,13 +77,18 @@ interface UpdateBundleLimitsOptions {
7677

7778
export function updateBundleLimits({ log, config, dropMissing }: UpdateBundleLimitsOptions) {
7879
const limits = readLimits();
79-
const metrics = getMetrics(config);
80+
const metrics: CiStatsMetrics = config.bundles
81+
.map((bundle) =>
82+
JSON.parse(Fs.readFileSync(Path.resolve(bundle.outputDir, 'metrics.json'), 'utf-8'))
83+
)
84+
.flat()
85+
.sort((a, b) => a.id.localeCompare(b.id));
8086

8187
const pageLoadAssetSize: NonNullable<Limits['pageLoadAssetSize']> = dropMissing
8288
? {}
8389
: limits.pageLoadAssetSize ?? {};
8490

85-
for (const metric of metrics.sort((a, b) => a.id.localeCompare(b.id))) {
91+
for (const metric of metrics) {
8692
if (metric.group === 'page load bundle size') {
8793
const existingLimit = limits.pageLoadAssetSize?.[metric.id];
8894
pageLoadAssetSize[metric.id] =

packages/kbn-optimizer/src/optimizer/get_output_stats.ts

Lines changed: 0 additions & 21 deletions
This file was deleted.

packages/kbn-optimizer/src/optimizer/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,3 @@ export * from './watch_bundles_for_changes';
1414
export * from './run_workers';
1515
export * from './bundle_cache';
1616
export * from './handle_optimizer_completion';
17-
export * from './get_output_stats';

0 commit comments

Comments
 (0)