Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): assure puppeteer_skip_chromium_download is applied across every yarn install situation #88346

Merged
merged 2 commits into from
Jan 14, 2021
Merged

chore(NA): assure puppeteer_skip_chromium_download is applied across every yarn install situation #88346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18a6f1f
chore(NA): assure puppeteer_skip_chromium_download is applied across …
mistic Jan 14, 2021
bc63f78
Merge remote-tracking branch 'upstream/master' into clean-tmp-puppete…
mistic Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(NA): assure puppeteer_skip_chromium_download is applied across … 
…every yarn install situation
  • Loading branch information
@mistic
mistic committed Jan 14, 2021
commit 18a6f1fc9e077a360c5b13b9a064a589fc75a9ff
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
puppeteer_skip_chromium_download=true
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"number": 8467,
"sha": "6cb7fec4e154faa0a4a3fee4b33dfef91b9870d9"
},
"config": {
"puppeteer_skip_chromium_download": true
},
"homepage": "https://www.elastic.co/products/kibana",
"bugs": {
"url": "http://github.com/elastic/kibana/issues"
Expand Down
5 changes: 4 additions & 1 deletion src/dev/build/tasks/clean_tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ export const CleanPackages: Task = {
description: 'Cleaning source for packages that are now installed in node_modules',

async run(config, log, build) {
await deleteAll([build.resolvePath('packages'), build.resolvePath('yarn.lock')], log);
await deleteAll(
[build.resolvePath('packages'), build.resolvePath('yarn.lock'), build.resolvePath('.npmrc')],
log
);
},
};

Expand Down
1 change: 1 addition & 0 deletions src/dev/build/tasks/copy_source_task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const CopySource: Task = {
dot: false,
select: [
'yarn.lock',
'.npmrc',
'src/**',
'!src/**/*.{test,test.mocks,mock}.{js,ts,tsx}',
'!src/**/mocks.ts', // special file who imports .mock files
Expand Down