Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): assure puppeteer_skip_chromium_download is applied across every yarn install situation #88346

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 14, 2021

We had a package.json config in order to skip the puppeteer local chromium download. However it appears it was only working for the general kbn bootstrap. That change will allow us to make it work also on our build process otherwise local chromium will be downloaded and we will experience the following error on macOS environment

 info [  kibana  ] Checking Windows for paths > 200 characters
   │ERROR failure 1 sec
   │ERROR Error: Windows has a path limit of 260 characters so we limit the length of paths in Kibana to 200 characters  and the following files exceed this limit:
   │       - node_modules/puppeteer/.local-chromium/mac-809590/chrome-mac/Chromium.app/Contents/Frameworks/Chromium Framework.framework/Helpers/Chromium Helper (Renderer).app/Contents/MacOS/Chromium Helper (Renderer)

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.11.1 labels Jan 14, 2021
@mistic mistic requested a review from tylersmalley January 14, 2021 15:43
@mistic mistic requested a review from a team as a code owner January 14, 2021 15:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.8MB 1.8MB -51.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.2KB 60.1KB -51.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit be1eb4c into elastic:master Jan 14, 2021
@mistic
Copy link
Member Author

mistic commented Jan 14, 2021

7.x/7.12: 049b45f
7.11/7.11.1: 1a7b475

@tsullivan
Copy link
Member

I have found this issue while researching into using the "stock" chromium for MacOS and Windows, instead of doing a custom build. It looks like if we take the default approach to making that happen, then we would run into this bug again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants