-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): assure puppeteer_skip_chromium_download is applied across every yarn install situation #88346
chore(NA): assure puppeteer_skip_chromium_download is applied across every yarn install situation #88346
Conversation
…every yarn install situation
…er-local-chromium
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
…every yarn install situation (elastic#88346)
…every yarn install situation (elastic#88346)
I have found this issue while researching into using the "stock" chromium for MacOS and Windows, instead of doing a custom build. It looks like if we take the default approach to making that happen, then we would run into this bug again. |
We had a
package.json
config in order to skip the puppeteer local chromium download. However it appears it was only working for the generalkbn bootstrap
. That change will allow us to make it work also on our build process otherwiselocal chromium
will be downloaded and we will experience the following error on macOS environment