[Security Solution] Fix 'disable usage data here.' link #86452
Conversation
angorayc
added
Team: SecuritySolution
|
@elasticmachine merge upstream |
| * Link to Advanced Settings. | ||
| */ | ||
| export const PATH_TO_ADVANCED_SETTINGS = 'management/kibana/settings'; | ||
| export const PATH_TO_ADVANCED_SETTINGS = '/app/management/kibana/settings'; |
There was a problem hiding this comment.
nit -> I think is better to remove the first trailing slash (app/management/kibana/settings) and leave it to the consumer to add it. It is better than having to remove it.
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
Thank you for doing this change!
I noticed the HTTP property is missing when building the mocks at src/plugins/telemetry/public/mocks.ts. Do you mind adding it?
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
it LGTM! thank you for doing this! I see other plugins already benefitting from this change.
Tested locally 👍
💚 Build SucceededMetrics [docs]Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
* fix 'disable usage data here.' link * update snapshot * update link * update mocks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* fix 'disable usage data here.' link * update snapshot * update link * update mocks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
4 participants
Summary
#86266
Expected Result:
http://localhost:5601/app/management/kibana/settings" link should be open, instead of "http://localhost:5601/app/security/management/kibana/settings"
before the fix it was
Checklist
features that require explanation or tutorials