[Security Solution][Endpoint][Admin] Disables malware checkbox when switch is off and can now save in detect mode #86402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkiino
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
kevinlog
approved these changes
Dec 17, 2020
Contributor
|
can you also add the v7.12 label? |
Contributor
|
And also, can you add a quick gif to show the change? |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
To update your PR or re-run it, just comment with: |
This was referenced Dec 18, 2020
parkiino
added a commit
to parkiino/kibana
that referenced
this pull request
Dec 18, 2020
…witch is off and can now save in detect mode (elastic#86402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users cannot switch the malware protection mode to detect when on a basic license. This is because the radio buttons and the user notification checkbox are highly connected. This PR fixes this bug by adding an additional check to see if the license is platinum+ before automatically checking the user notification checkbox when the user switches between "prevent" and "detect" malware.
Issues:
#86073
https://github.com/elastic/security-team/issues/585